search

sogno-platform / dpsim

Real-time power system simulator including powerflow, (dynamic) phasors and EMT
https://sogno.energy/dpsim/
Mozilla Public License 2.0
70 stars 51 forks source link

Disable VILLASfpga to remove libxil dependency #232

Closed JTS22 closed 1 year ago

JTS22 commented 1 year ago

Sets the WITH_FPGA=OFF compile flag for VILLASnode in the Dockerfile.dev to remove a dependency on the shared library libxil, which is currently not installed in the container. Merging this PR should probably be followed by an update for the images on Docker Hub via the container workflow. Closes #231

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

n-eiling commented 1 year ago

This is better fixed by this: https://github.com/VILLASframework/node/pull/694 which includes this https://github.com/VILLASframework/libxil/pull/8 which fixes the install path for libxil.so. It was installed to /usr/local/lib while all other villas libraries were installed to /usr/local/lib64

stv0g commented 1 year ago

I agree with @n-eiling

JTS22 commented 1 year ago

Great, thank you @n-eiling @stv0g ! I added the use of the updated VILLASnode version as a solution in #231.

dinkelbachjan commented 1 year ago

We will go for another solution as described in #231