search

sogno-platform / dpsim

Real-time power system simulator including powerflow, (dynamic) phasors and EMT
https://sogno.energy/dpsim/
Mozilla Public License 2.0
67 stars 49 forks source link

Compilation warnings and some code improvements #256

Closed leonardocarreras closed 4 months ago

leonardocarreras commented 11 months ago

Description of the bug During compilation in a new environment, errors related to "-Woverloaded-virtual" problems with the compiler arise in various files related to SynchronGenerator* classes and the missing argument Int timeStepCount in the DIakopticsSolver logger

To Reproduce Steps to reproduce the behavior:

  1. Install a new environment
  2. Install dependencies
  3. Compile with cmake --build . -j4 --target dpsimpy

Expected behavior Build successful

Desktop (please complete the following information):

Additional context This warning could also be ignored with pragma instructions, but we actually want to override it, as reading the intention in the code.

The warning is of type: warning: 'DerivedClass::function' hides overloaded virtual function [-Woverloaded-virtual]

n-eiling commented 4 months ago

fixed by #293