search

sogno-platform / dpsim

Real-time power system simulator including powerflow, (dynamic) phasors and EMT
https://sogno.energy/dpsim/
Mozilla Public License 2.0
67 stars 49 forks source link

CI Flow does not work for Dockerfile changes #301

Open n-eiling opened 4 weeks ago

n-eiling commented 4 weeks ago

Because the CI does not build the dev container but instead uses one that has to be build manually, we cannot properly check changes to the Dockerfile.

I feel like the switch to the github actions really was a regression in many ways. With the gitlab runner we used to build the containers for each PR separately and were still faster than github.

Has anyone somehow tested changes to the dockerfiles without just pushing a new image to the registry and hoping for the best?

georgii-tishenin commented 4 weeks ago

Hi, @n-eiling, I am pretty new to this topic and have not yet made any changes to the dockerfiles. Do you already have some ideas to improve on testing the changes of the Dockerfile? E.g., can the dev container build be automated?

n-eiling commented 4 weeks ago

yes, but afaik it was removed because it took too long. The only solution I see is moving to self hosted runners. Or define a workflow for Dockerfile changes that avoids this.

m-mirz commented 4 weeks ago

As @n-eiling mentioned, we already had this automated but building the container images in the ci takes forever since we only use free resources in GitHub. So currently, the docker build job is triggered manually in the actions menu.