search

sogou / SogouMRCToolkit

This toolkit was designed for the fast and efficient development of modern machine comprehension models, including both published models and original prototypes.
Apache License 2.0
746 stars 162 forks source link

several minor errors of Trainer #6

Closed threefoldo closed 5 years ago

threefoldo commented 5 years ago

This framework is handy, I like it. Here are several problems I found:

  1. Trainer._evaluate requires 'model_path', but BaseModel doesn't provide that parameter;

  2. Trainer._inference call Trainer.inference (with 3 parameters) which doesn't exists.

Also, the default logging level disable all training information, that's inconvenient. At the end of training, there is no information of training at all.

yylun commented 5 years ago

Thanks for pointing out these bugs, 1&2 should be a version problem, will fix that soon

Currently we enable the logging information by adding

logging.getLogger().setLevel(logging.INFO)
os.environ["TF_CPP_MIN_LOG_LEVEL"] = "3"
threefoldo commented 5 years ago

Thanks.