search

sohamkamani / three-object-loader

[DEPRECATED] NodeJS wrapper for Three.js' OBJLoader function
30 stars 31 forks source link

Errors due to bad obj files throw exceptions instead of calling onError #13

Closed JakeDluhy closed 7 years ago

JakeDluhy commented 7 years ago

I was expecting that if my obj was bad/corrupted for whatever reason, then onError would be called when attempting to parse it. However that is not the case, it just throws an exception.

I'd be willing to submit a PR for this

JakeDluhy commented 7 years ago

Changes in #14. Would be willing to make them again once #12 gets merged in.

JakeDluhy commented 7 years ago

@sohamkamani can you release a new npm version? And then we can close this out

sohamkamani commented 7 years ago

Done 👍 Thanks for the help!

JakeDluhy commented 7 years ago

No problem!