search

sohamkamani / three-object-loader

[DEPRECATED] NodeJS wrapper for Three.js' OBJLoader function
30 stars 31 forks source link

Update OBJLoader #18

Closed ashlinaronin closed 6 years ago

ashlinaronin commented 6 years ago

I noticed that there are two older unmerged PRs (#12, #15) having to do with updating the OBJ Loader. In the meantime, it's gotten updated again. This PR simply pulls in the latest OBJ loader from https://github.com/mrdoob/three.js/blob/8af1260742e400c1b63f9e77dc4c8214bb283ab2/examples/js/loaders/OBJLoader.js

This latest version eliminates the console warning:

three.module.js:43338 THREE.MeshPhongMaterial: .shading has been removed. Use the boolean .flatShading instead.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+2.3%) to 5.106% when pulling 2adf52384e51c8527ae0f2639ada1f73ab5e74de on ashlinaronin:update-obj-loader into 0508e276ed0d0c99b8d1a2517e6f013cdd3f96bc on sohamkamani:master.

dionsnoeijen commented 6 years ago

Aha, I was doing the same thing... ;). Can this be merged?

coveralls commented 6 years ago

Coverage Status

Coverage increased (+2.3%) to 5.15% when pulling 52cf4fb3c87b3e7018832bf95a62260fdd072892 on ashlinaronin:update-obj-loader into 0508e276ed0d0c99b8d1a2517e6f013cdd3f96bc on sohamkamani:master.

ashlinaronin commented 6 years ago

Closing because given the fact there are two other stale PRs for the same issue, the owner doesn't appear to have any interest in maintaining this repo / module. I'm just going to point to my fork going forward.