Fixed two annoying warnings

esnho commented 6 years ago

As can be seen from the commits I fixed two warning, one is about the new .flatShading flag, the other is about using array of materials instead of the Multimaterial object.

sohamkamani commented 6 years ago

Thanks! Unfortunately the build is failing. Could you please test the build on your end?

esnho commented 6 years ago

Hi, here the build is ok, I don't know why is failing.


Mac-Pro-di-Mac:three-object-loader macpro2$ npm run test

> three-obj-loader@1.1.3 test /Users/macpro2/three-object-loader
> gulp test

[12:26:28] Using gulpfile ~/three-object-loader/gulpfile.js
[12:26:28] Starting 'clean:all'...
[12:26:28] Finished 'clean:all' after 28 ms
[12:26:28] Starting 'test'...
[12:26:28] Starting 'source:build'...
[12:26:28] Starting 'test:build'...
[12:26:28] Starting 'watch'...
[12:26:28] Finished 'watch' after 14 ms
[12:26:28] Finished 'test' after 34 ms

source/index.js
  line 218  col 104  Strings must use singlequote.
  line 414  col 29   'l' is already defined.
  line 516  col 63   Strings must use singlequote.
  line 516  col 76   Strings must use singlequote.
  line 520  col 41   Strings must use singlequote.
  line 569  col 51   Strings must use singlequote.
  line 569  col 64   Strings must use singlequote.
  line 573  col 41   Strings must use singlequote.
  line 575  col 61   Strings must use singlequote.
  line 578  col 31   Strings must use singlequote.
  line 586  col 50   Strings must use singlequote.
  line 588  col 34   Strings must use singlequote.
  line 589  col 34   Strings must use singlequote.
  line 604  col 26   Strings must use singlequote.
  line 646  col 44   Strings must use singlequote.
  line 646  col 57   Strings must use singlequote.
  line 657  col 16   'i' is already defined.
  line 657  col 23   'l' is already defined.
  line 694  col 15   'material' is already defined.
  line 730  col 20   'mi' is already defined.
  line 730  col 28   'miLen' is already defined.
  line 732  col 17   'sourceMaterial' is already defined.

  ⚠  22 warnings

[12:26:29] Finished 'source:build' after 610 ms
[12:26:29] Finished 'test:build' after 593 ms
[12:26:29] Starting 'build:all'...
[12:26:29] Finished 'build:all' after 1.81 μs
[12:26:29] Starting 'test:all'...

  OBJLoader Wrapper
    ✓ THREE does not contain OBJLoader by default
    ✓ Assigns THREE.OBJLoader as a function once called
    ✓ Is an instance of ObjectLoader

  3 passing (7ms)

[12:26:29] Finished 'test:all' after 130 ms

Mac-Pro-di-Mac:three-object-loader macpro2$ npm run compile

> three-obj-loader@1.1.3 compile /Users/macpro2/three-object-loader
> gulp build

[12:30:12] Using gulpfile ~/three-object-loader/gulpfile.js
[12:30:12] Starting 'clean:dist'...
[12:30:12] Finished 'clean:dist' after 25 ms
[12:30:12] Starting 'build'...
[12:30:12] Finished 'build' after 351 ms

Mac-Pro-di-Mac:three-object-loader macpro2$ npm run prepublish

> three-obj-loader@1.1.3 prepublish /Users/macpro2/three-object-loader
> npm run compile

> three-obj-loader@1.1.3 compile /Users/macpro2/three-object-loader
> gulp build

[12:30:22] Using gulpfile ~/three-object-loader/gulpfile.js
[12:30:22] Starting 'clean:dist'...
[12:30:22] Finished 'clean:dist' after 24 ms
[12:30:22] Starting 'build'...
[12:30:22] Finished 'build' after 340 ms

antonioblancato commented 5 years ago

@esnho @sohamkamani I guess the failing compilation is related to gulpjs/gulp#2162. The solution is to remove the yarn.lock. This worked for me:

rm yarn.lock
yarn cache clean
yarn install

(Not sure whether clearing the cache is necessary though)

esnho commented 5 years ago

Thank you @antonioblancato removing the yarn.lock did the job.

@sohamkamani please can you check the pull again?

sohamkamani / three-object-loader

Fixed two annoying warnings #19