search

soheilhy / cmux

Connection multiplexer for GoLang: serve different services on the same port!
Apache License 2.0
2.53k stars 197 forks source link

misc cleanup #5

Closed tamird closed 8 years ago

tamird commented 8 years ago

Also pass golint and errcheck.

tamird commented 8 years ago

@soheilhy ping

soheilhy commented 8 years ago

hehe, some of my comments were in your commit not on the pull request. :))

Thanks for doing this, again!

tamird commented 8 years ago

ok, PTAL.

tamird commented 8 years ago

It's not possible to revert the examples if you still intend to run them. Serving on the socket blocks, so the example would never terminate.

soheilhy commented 8 years ago

That's right, and nor does any example in the net/http package. It's fine to have package examples block (I mean that ones that are shown with package "main" by godoc).

And sorry for the late reply, didn't receive an email on this.

tamird commented 8 years ago

I'm just going to maintain a fork. Thanks.

On Sat, Feb 20, 2016 at 1:57 PM, Soheil Hassas Yeganeh < notifications@github.com> wrote:

That's right, and nor does any example in the net/http package. It's fine to have package examples block (I mean that ones that are shown with package "main" by godoc).

And sorry for the late reply, didn't receive an email on this.

— Reply to this email directly or view it on GitHub https://github.com/soheilhy/cmux/pull/5#issuecomment-186666404.

tamird commented 8 years ago

Feel free to merge all but the last commit if you want.

tamird commented 8 years ago

I've removed the last commit.

soheilhy commented 8 years ago

Manually edited and merged, except "go tool vet --shadow ." thanks for the effort!