Use new gRPC matcher for README example

soheilhy / cmux

Connection multiplexer for GoLang: serve different services on the same port!

Apache License 2.0

2.58k stars 199 forks source link

Use new gRPC matcher for README example #90

Open johanbrandhorst opened 2 years ago

johanbrandhorst commented 2 years ago

gRPC-Go has been waiting for the settings frame for a while now (https://github.com/soheilhy/cmux/issues/64), and having the old handler in the example is confusing users (https://github.com/soheilhy/cmux/issues/67). Use the new handler in the example and remove the "Limitations" from the README.

Bingmang commented 2 years ago

Meet the same issue, please merge this PR.

dkrieger commented 7 months ago

still a problem. @soheilhy would an update to the "Limitations" section to include "golang and other c-wrapped implementations" be more amenable? As I understand it the performance issue with MatchWithWriters (caused by sending settings more than once) was resolved, so maybe it's ok to change the default example now

edhemphill commented 3 months ago

Glad i found this... mucked around for hours wondering what the issue was.