fix separator error, height dropdown error

sohobloo / react-native-modal-dropdown

A react-native dropdown/picker/selector component for both Android & iOS.

MIT License

1.19k stars 478 forks source link

fix separator error, height dropdown error #228

Open vitorizkiimanda opened 4 years ago

vitorizkiimanda commented 4 years ago

Separator not working, fixed by change '||' into '&&' -> logical error Dropdown height hardcoded leading to missing height modal on dynamic options number, fixed by deleting height on style -> styling error

michaeldawson commented 4 years ago

Hey @vitorizkiimanda, I'm not a contributor to this library but I can let you know that your pull request can't be considered while it includes all of these unrelated changes, including changing indentation.

Try to reduce your PR to only the lines that provide the change in behaviour, which might include line 413. Also, it's not usual practice to add a line like "* Modifiedd by vitorizkiimanda on 19/01/10." with your PR.