search

sohobloo / react-native-modal-dropdown

A react-native dropdown/picker/selector component for both Android & iOS.
MIT License
1.19k stars 477 forks source link

Update ListView to Flatlist #230

Open marshallshen opened 5 years ago

marshallshen commented 5 years ago

Background

The original problem is caused by RN deprecating ListView in favor of FlatList, a solution is merged here.

However, a better solution IMO is to upgrade ListView entirely.

Testing

yarn test result with react-native-modal-dropdown 0.70:

Screen Shot 2019-10-15 at 8 34 47 AM

yarn test result with the PR fork

Screen Shot 2019-10-15 at 8 36 45 AM
marshallshen commented 5 years ago

@sohobloo - any updates I should make for this?

nathan-pierotti commented 5 years ago

I had the same issue as well. Please merge this PR

Rahulv2492 commented 4 years ago

I am also getting same issue please merge this PR. @sohobloo

Rahulv2492 commented 4 years ago

Any update on this @sohobloo .

marshallshen commented 4 years ago

@Rahulv2492 : also feel free to use the forked package as we keep it up to date: https://github.com/BuildU/react-native-modal-dropdown

In your package.json you need to import it as buildu/react-native-modal-dropdown

Gp2mv3 commented 4 years ago

Any update? We also see the same issue in our tests.

irekrog commented 4 years ago

@Gp2mv3 I had a some problem and I added below line to my test. It works now.

jest.mock('deprecated-react-native-listview', () => {});

But still is a only workaround. @marshallshen's solution is better because replace depracated ListView

ivankdev commented 4 years ago

++ issue, update please

gusrodriguez commented 3 years ago

This should be merged to make the package usable.