sohobloo / react-native-modal-dropdown

A react-native dropdown/picker/selector component for both Android & iOS.
MIT License
1.19k stars 477 forks source link

React Native 0.62 support #245

Open kesha-antonov opened 4 years ago

kesha-antonov commented 4 years ago

Hi!

When building with RN 0.62 it gives error:

error: Error: Unable to resolve module `react-native/Libraries/vendor/core/isEmpty` from `node_modules/deprecated-react-native-listview/index.js`: react-native/Libraries/vendor/core/isEmpty could not be found within the project.
irekrog commented 4 years ago

@kesha-antonov https://github.com/sohobloo/react-native-modal-dropdown/pull/244 I have created PR with fix but I'm not sure if will be merged because looks like this project is not maintained anymore

kesha-antonov commented 4 years ago

Awesome! Let's mention repo owner @irekrog

vipycm commented 4 years ago

you can temporarily fix this error by add this config to package.json "resolutions": { "deprecated-react-native-listview": "0.0.6" }

omar-dulaimi commented 4 years ago

you can temporarily fix this error by add this config to package.json "resolutions": { "deprecated-react-native-listview": "0.0.6" }

What to do after that? npm install? cuz it didn't work!

EDIT: turns out I had version 0.0.5 installed and thats why it didn't work. After installing v0.0.6 it worked!

Thank you!

zepvi commented 4 years ago

@omar-dulaimi How did u installed v0.0.6 of "deprecated-react-native-listview"

omar-dulaimi commented 4 years ago

@zepvi In package.json it was already a dependency like this: "deprecated-react-native-listview": "^0.0.5", So I changed it to 6 then added this line to package.json:

"resolutions": {
    "deprecated-react-native-listview": "0.0.6"
  },

then npm i

Hope it works for you!

zanlucathiago commented 4 years ago

Just want to point out that this solution doesn't work with react-native-modal-dropdown version 0.7.0. You can fix it to 0.6.2.

palmer95 commented 4 years ago

@zanlucathiago and how exactly do you do that?

zanlucathiago commented 4 years ago

@palmer95 You can fix it in package.json.

{ "dependencies": { "react-native-modal-dropdown": "0.6.2" } }

Bilal-Abdeen commented 4 years ago

Check out #251

senthilkumar3282 commented 4 years ago

@palmer95 You can fix it in package.json.

{ "dependencies": { "react-native-modal-dropdown": "0.6.2" } }

this one is working for me

uyend commented 4 years ago

Just wanting to put a note that this doesn't work for RN 0.63+

Balasnest commented 4 years ago

It didn't work with 0.7.0 and 0.6.2 Any workaround for 0.63.+ ?

JayeshPatil-Dev commented 4 years ago

Any work around for 0.63+?

tim92109 commented 3 years ago

Please remove this deprecated out of date package so people stop trying to use it!!!

fqborges commented 3 years ago

Use v0.6.2. A good community member makes a PR instead of complaining. Just saying.

tim92109 commented 3 years ago

Guessing that was aimed at me @fqborges I agree but somebody has to state the obvious too or number of packages that need updates to continue working are going to keep increasing

fqborges commented 3 years ago

@tim92109 Sorry if it sounded aggressive, it shouldn't. And yes, you are right, someone has to state the obvious sometimes. But, try to no be so harsh on open source developers, they own you nothing.

tim92109 commented 3 years ago

Advice taken, @fqborges & thanks