soilwise-he / link-liveliness-assessment

MIT License
0 stars 1 forks source link

a deprecated status after 10 failed tests #9

Open pvgenuchten opened 1 month ago

pvgenuchten commented 1 month ago

If a resource continues to fail (10 tests), it could be excluded for subsequent tests, its status can be set to 'deprecated'

You think this is a good idea, to keep the service performant?

Definition of Done

vgole001 commented 1 week ago

It looks like a good idea to me. Probably we can set the number of failures to be flexible since it is depended on how often the tests run.

Concering the implementation
we can update the database to keep track of cummulative failures of a particular url in order to set it as deprecated Some failure codes that would be fair to take into consideration 4xx Client Error Codes: [400,401,403,404,405,409] 5xx Server Error Codes: [500, 501, 503, 504]

vgole001 commented 1 week ago

To add some other thoughts on this issue Excluding a deprecated url from future checks although it offers efficiency by reducing the total URL's to check it prevents us from detecting weather a previously deprecated URL has become available again. Over time fewer and fewer links potentially will be checked and important information may be lost, since we dont have the opportunity to check the status of a deprecated url that has been been started working again. False positives can also occur due to temporary issues rather than actual URL failures setting the URL to be invalid and consecutively deprecated.