search

soimort / translate-shell

:speech_balloon: Command-line translator using Google Translate, Bing Translator, Yandex.Translate, etc.
https://www.soimort.org/translate-shell
The Unlicense
6.83k stars 387 forks source link

Update MS Edge user client string #496

Closed naltun closed 10 months ago

naltun commented 10 months ago

In Main.awk, the MS Edge user client is specfied as Edg. Change this to Edge.

Not sure if this was intentional or not, please ignore if so. :+1: :rocket:

soimort commented 10 months ago

Can you confirm if the latest Microsoft Edge UA string is Edg or Edge?

I don't have the Edge browser installed right now, but according to Microsoft's own documentation, it's just "Edg": https://learn.microsoft.com/en-us/microsoft-edge/web-platform/user-agent-guidance#user-agent-strings

Also according to this stackoverflow comment: https://stackoverflow.com/questions/30591706/what-is-the-user-agent-string-name-for-microsoft-edge#comment122093306_33505753 , it was changed from Edge to Edg since 2019.

naltun commented 10 months ago

@soimort you are correct, the modern user agent is Edg. When I went to confirm this, I was looking at outdated documentation from 2017. This PR can be disregarded. :pray: