search

soimy / msdf-bmfont-xml

Generate BMFont texture and spec XML using msdfgen
https://soimy.github.io/msdf-bmfont-xml/
MIT License
315 stars 46 forks source link

Binaries not executable in 2.3.2 #19

Closed donmccurdy closed 6 years ago

donmccurdy commented 6 years ago

The binaries in the 2.3.2 release don't seem to be executable:

screen shot 2018-02-09 at 4 26 02 pm

A manual chmod after installation fixes the issue. I don't see anything in the commit history to explain that. 😕

I am using macOS here.

soccerob commented 6 years ago

I'm not able to run anything with this latest version. after installing via npm, i get errors when attempting to run msdf-bmfont -v i tried chmod with no success

msdf-bmfont -v module.js:672 return process.dlopen(module, path._makeLong(filename)); ^

Error: The module '/usr/local/lib/node_modules/msdf-bmfont-xml/node_modules/canvas-prebuilt/canvas/build/Release/canvas.node' was compiled against a different Node.js version using NODE_MODULE_VERSION 46. This version of Node.js requires NODE_MODULE_VERSION 57. Please try re-compiling or re-installing the module (for instance, using npm rebuild or npm install). at Object.Module._extensions..node (module.js:672:18) at Module.load (module.js:556:32) at tryModuleLoad (module.js:499:12) at Function.Module._load (module.js:491:3) at Module.require (module.js:587:17) at require (internal/module.js:11:18) at Object. (/usr/local/lib/node_modules/msdf-bmfont-xml/node_modules/canvas-prebuilt/canvas/lib/bindings.js:3:18) at Module._compile (module.js:643:30) at Object.Module._extensions..js (module.js:654:10) at Module.load (module.js:556:32)

soimy commented 6 years ago

@donmccurdy sorry, this is due to new version submitted to npm via windows... I'll fix that

soimy commented 6 years ago

@soccerob what version of node are you using? This error is related to canvas-prebuilt module. Try a clean remove and reinstall msdf-bmfont-xml might solve this.

soimy commented 6 years ago

Fixed via bca20ca24bfcf1e7d03ffd43550953dfbeecc6c6

donmccurdy commented 6 years ago

Thanks @soimy! With that update I no longer have to compile from the fork, and see no artifacts. 🙂 But it does not seem like this issue is fixed — none of the binaries appear to be executable.

soimy commented 6 years ago

尴尬！Fixed via 5f8f2901bf521ca2c98343685a23fd690ebe26f1 Thanks for reporting this @donmccurdy Haven't figure out a way to keep executable permission while running npm publish via windows

donmccurdy commented 6 years ago

Working perfectly now, thanks! 🎊