soixantecircuits / cropcrop

A tool for cropping video easily online
0 stars 1 forks source link

test.php is forbidden, wrong name does not name nothing :) #86

Open gabrielstuff opened 11 years ago

gabrielstuff commented 11 years ago

http://cropcrop.soixantecircuits.fr/server/php/test.php

this is ugly :facepunch:

and the call to :

http://cropcrop.soixantecircuits.fr/server/php/test.php http://cropcrop.soixantecircuits.fr/server/php/test2.php

is a nonsens ? This two files :

https://github.com/soixantecircuits/cropcrop/blob/master/server/php/test.php https://github.com/soixantecircuits/cropcrop/blob/master/server/php/test2.php

Should be merge and using something like $_POST['thumbnails'] which contains a number.

Asking for 1 give 1, asking for 5 give 5

saschmitt commented 11 years ago

in fact after reading those files, they are differents. One get video informations and send the main thumbnail The other send thumbnails. They have been renamed getVideoInformations.php and getThumbnails.php .

gabrielstuff commented 11 years ago

ok so, one php file should :

getVideInformations.php and only this !

the other getThumbnails should handle parameters to choose from one to ten thumbnails generation.

thanks for the work.