search

soixantecircuits / idle-vue

Vue component wrapper for idle-js
MIT License
125 stars 40 forks source link

Fix the build problem. Fix #17 #19

Closed afonso closed 6 years ago

joefresco commented 7 years ago

From looking at the code generated, it looks like \n is being interpreted as a string instead of a literal on the code committed.

I'm not a maintainer, but all the build.js files I've seen are formatted with typical new lines per statement/structure and indented for readability. My own project's build.js is like this and it also is automatically generated.

agnivade commented 7 years ago

This is a simple error which even prevents the project from being built. Should have been caught in the first place if there was a travis setup.

If this PR can be merged, I can send in a PR which adds travis.

gabrielstuff commented 6 years ago

Hi @agnivade ! We will review PR today and merge accordingly.

Just after, please feel free to add any CI that you feel intersting.

Thanks !

gabrielstuff commented 6 years ago

Thanks !

gabrielstuff commented 6 years ago

hey @afonso, sorry it took us so long. Would you mind flag as deprecated the duplicate version you published on npm. Hope we will move faster together.

Thanks !