search

soixantecircuits / idle-vue

Vue component wrapper for idle-js
MIT License
125 stars 40 forks source link

Don't include idle-vue component in default build #27

Closed GregPeden closed 4 years ago

GregPeden commented 6 years ago

For most people this is just bloat, most people will not use this component so you're just adding kB to their JS asset size. Just include it in the package as an example or to be extended or whatever. Anyone who wants to use this component can include it themselves.

For most people it will not work properly since it tried to request a PNG icon at a path that almost nobody will use.

gabrielstuff commented 6 years ago

Totally agree. This will be removed in the next version. In the mean time if you fix this, we will be happy to merge.

GregPeden commented 6 years ago

Okay I'll have a look.

gabrielboliveira commented 6 years ago

@gabrielstuff Firstly, nice package!

This issue is a nice addition. Do you intend to merge and publish?

Thanks.

gabrielstuff commented 6 years ago

Hello, Yes testing tomorrow with fixing https://github.com/soixantecircuits/idle-vue/issues/20

ThaDaVos commented 6 years ago

When will this be merged?

GregPeden commented 4 years ago

I see this was merged in but a new release was not published to NPM.

https://github.com/soixantecircuits/idle-vue/pull/28

gabrielstuff commented 4 years ago

Will publish tonight.