search

soixantecircuits / idle-vue

Vue component wrapper for idle-js
MIT License
125 stars 40 forks source link

Remove 'idle-vue' component from base build #28

Closed GregPeden closed 5 years ago

GregPeden commented 6 years ago

Per this issue: https://github.com/soixantecircuits/idle-vue/issues/27

This removes the idle-vue component from the base build to save on the package size. It cuts it down from about 13kb to 4kb before gzip compression.

GregPeden commented 6 years ago

Just a reminder that this is just sitting here waiting for adoption.

blalan commented 6 years ago

This looks great! Can we get this merged?

GregPeden commented 6 years ago

The package author indicated in a separate issue thread that they would accept this PR but there has been no activity since.

In the meantime, if you want, you can grab this package from here.

https://github.com/SirLamer/idle-vue/tree/remove-example-component

Keep in mind that I may remove this one day if the code is ever merged in to this project.

gabrielstuff commented 5 years ago

Hello @SirLamer, after a long reflexion :) I'll merge this. The component does not have to do anything in there and should be released in a separate component.

Thanks for your contribution.

GregPeden commented 5 years ago

Thanks for merging! Don't forget to publish. ;-)