sojhalb / CuraEngine

CuraEngine is a powerful, fast and robust engine for processing 3D models into 3D printing instruction for Ultimaker and other GCode based 3D printers. It is part of the larger open source project called "Cura".
https://ultimaker.com/en/products/cura-software
GNU Affero General Public License v3.0
0 stars 0 forks source link

Fix top-bottom skins for supported non-wrapping layers #3

Closed nguyri closed 5 years ago

nguyri commented 5 years ago

There is still a seam and that's unfortunate.

nguyri commented 5 years ago

Modified the seam handling to flop back and forth and disabled top/bottom skins. Technically it should be smart enough to find out the cases where it should do a top skin and where it shouldn't based on the polygons' has_digon flag but I'm not smart enough to figure that out yet

nguyri commented 5 years ago

Kind of a mouthful but basically the little peaks on the cube used to have solid filled pads to sit on so they were well supported when printed. Those went away.

nguyri commented 5 years ago

Fixed top skin (specifically in test cube and test cylinder) with some limitations, namely the flip-flopping seam is still treated as overhanging in the layers where top skin is enabled for the test cube. There isn't a way of fixing this without some proper digon handling so this is as good as it's going to get. The result is exactly what you'd expect for the test cylinder however.