search

sojinantony01 / react-cron-generator

Simple react component to generate cron expressions
MIT License
78 stars 62 forks source link

use explicit componentName attribute in metadata so that getting the … #24

Closed bobgonzalez closed 3 years ago

bobgonzalez commented 3 years ago

…component can be done even if minifiers / tersers reduce or mangle the component names.

mawaruDOLL commented 3 years ago

@sojinantony01 This is something I need as well. In my implementation, I used the values from HEADER_VALUES as a name in the metadata array so I was able to compare the tab value in getComponent() inside of cron.js to the metadata name attribute directly rather than having to concatenate with 'Cron'. But either way works as long as the library can support minification so I didn't make any additional pull requests with my code changes.

[Edit] Maybe a new pull request is necessary since this one wouldn't support the custom tab as-is.

sojinantony01 commented 3 years ago

Merging #30 which contains similar chane