sojinantony01 / react-cron-generator

Simple react component to generate cron expressions
MIT License
78 stars 62 forks source link

Hourly tab: unable to set 0 hour #60

Closed davidcaldas closed 3 months ago

davidcaldas commented 3 months ago

Hello!

When we enter in the Hourly tab the hour value is 0 and the result expression is "0 0 0/1 1/1 ? ".

If we change the hour time e trying go back to 0 is not possible, the input only allow an empty value but the expression value is "0 0/1 1/1 ? ".

As we can see they are different: "0 0 0/1 1/1 ? " "0 0/1 1/1 ? "

Best Regards, David

sojinantony01 commented 3 months ago

Hi David Thanks for reporting the issue. I will try to fix ASAP

sojinantony01 commented 3 months ago

Hi from the above steps, i can understand you are trying to create a cron with zero hour and certain minutes. like 0 hour 15 minutes, for this kind of selection you can to select minute tab instead of hourly tab.

Regarding the value difference, an empty hourly value is getting added to cron expression and cron consider it as a 6 value cron expression.

davidcaldas commented 3 months ago

Hello @sojinantony01 !

Sorry, but I make a mistake in the description of the error. The problem I describe is in the minutes input: (label is on right of the input) image

Best Regards, David