sojourn-13 / sojourn-station

Other
48 stars 252 forks source link

Refactor Disposals and remove Atmos Interactions #5480

Closed ShadowLarkens closed 1 week ago

ShadowLarkens commented 1 week ago

About The Pull Request

As title says, this refactors a bunch of really old disposals code, and notably removes all traces of using atmospherics.

Before, the way disposal units worked is actively pulling air from their surroundings into their box, then it'd ship it off to be expelled either at a pipe break or outlet.

Now, it just charges a percentage var to maintain nearly-identical recharge times and power usage, and no air is taken from the environment or deposited at the other end.

This feature just doesn't really vibe with our server, especially not having scrubbers turned on by default, this means that eventually every room with a disposals outlet will over-pressurize.

Changelog

:cl: tweak: Disposals no longer interact with air refactor: Disposals code refactored to be nicer refactor: Disposals now uses LateInitialize instead of cursed New->spawn()s to find and link machines fix: Disposals now respect mob size correctly /:cl: