Feedback from Stas

[stasRevin]

Design/Code Review 1

Project: Steve's Cash Register User Speed Tester

Developer: Steve Sokasits

Reviewer: Stanislav Revin

Item	Considerations	Comments/Suggestions
Reviewer comments and suggestions go here. Each item should have at least one "kudos" and two suggestions for improvement
Problem Statement	1. Accurately describes project purpose 2. Is professional and free of typos, slang, etc. 3. Fully explains the problem and the solution 4. Is understandable by the average person	1. Kudos to you and your wife for this great idea to test employees on how fast they can navigate the register screen. You can sell this app. 2. I know you just switched your project, so you might want to add your problem statement. 3. Update your project link in the student repository.
Design Documentation	1. Navigation/flow through the application is logical and easy to use. 2. The order in which values are displayed are logical and easy to understand/use 3. The order in which the form fields entered are logical and easy to understand/use 4. All data discussed/documented (problem statement, flow, db design, etc.) is represented on the screens	1. The navigation that you demonstrated looked logical and reflected what most companies use for their registers. 2. You can check out some jQuery UI libraries in case if you want to add some flare to the buttons on the screen. 3. Also I wasn't able to find design pictures in your repo.
Data model/Database	1. Everything on the screens and problem statement/flow is represented in the model 2. There is at least one 1-to-many relationship. 3. The model represents good database design	1. The database looks well-organized and planned. 2. Add ERD pictures to see the high-level design and relationships between entities. 3. Some rows had names like Mocha 12oz, you might want to consider breaking them down into separate columns like drink type and size.
Code	1. Proper Maven project structure is used 2. a .gitignore file for IntelliJ Java projects has been implemented 3. There is not any redundant or copy/paste code in the JSPs or classes 4. Classes are appropriately-sized (no monster classes) Property files are used appropriately: no hard-coded values 5. Logging statements are used rather than System.out.println and printStackTrace. 6. There are appropriate unit tests/code coverages.	1. The code that you demonstrated look clean and crispy. 2. You can use Generic Dao to do your CRUD work. 3. You can implement project Lombok to get rid of getters and setter. A big helper. 4. Take a look at AJAX and see if you want to use it in your project. It can help you avoid refreshing the page when the users will be clicking on buttons, so the page refreshing won't distract them from taking the test. Overall, good work, awesome idea.

[pawaitemadisoncollege]

Solid feedback here, @stasRevin . Well done. I agree that @sokasits31 could probably market this!