Update pWS chart version to 3.0

xiCO2k commented 3 years ago

Checked the https://helm.soketi.app/index.yaml to look for the 0.3.0 version and is not there.

Can you push it up?

Have the server running pretty good on local trying to have it running on my k8s :)

Thanks, Francisco

xiCO2k commented 3 years ago

Also got this error @rennokki when running

/app/node_modules/prom-client/lib/metric.js:36
            throw new Error('Invalid metric name');
                  ^

Error: Invalid metric name
    at new Metric (/app/node_modules/prom-client/lib/metric.js:36:10)
    at new Gauge (/app/node_modules/prom-client/lib/gauge.js:19:1)
    at PrometheusMetricsDriver.registerMetrics (/app/dist/metrics/prometheus-metrics-driver.js:65:31)
    at new PrometheusMetricsDriver (/app/dist/metrics/prometheus-metrics-driver.js:12:14)
    at new Metrics (/app/dist/metrics/metrics.js:10:27)
    at Server.start (/app/dist/server.js:164:31)
    at Cli.start (/app/dist/cli/cli.js:108:28)
    at Function.start (/app/dist/cli/cli.js:96:26)
    at /app/dist/cli/index.js:6:63
    at Object.runCommand (/app/node_modules/yargs/build/index.cjs:403:35)

xiCO2k commented 3 years ago

I will probably have the time to review more later this week. but if you have any insight let me know.

rennokki commented 3 years ago

Keep the version set to 2.1.1 until I'll upgrade the values and the chart to 3.x 😁

Can you share the configuration for your run? It seems like you activated Prometheus, but I want to know what other options you set.

xiCO2k commented 3 years ago

I did without any configs and the error happened, for what I checked on the code the prometheus driver is always imported:

export class Metrics implements MetricsInterface {
    /**
     * The Metrics driver.
     */
    protected driver: MetricsInterface;

    /**
     * Initialize the Prometheus exporter.
     */
    constructor(protected server: Server) {
        if (server.options.metrics.driver === 'prometheus') {
            this.driver = new PrometheusMetricsDriver(server);
        } else {
            Log.error('No metrics driver specified.');
        }
    }
}

directly on the Docker it seems to give no issue, so I'm guessing is something related to this vars, not having the correct value:

protected registerMetrics(): void {
    let port = this.server.options.port;
    let prefix = this.server.options.metrics.prometheus.prefix;
}

and give that validation error. looks pretty strait forward but probably related to that.

Thanks for the quick response. Francisco

rennokki commented 3 years ago

I have updated the pWS chart to 0.4.0, it seems like for some reason I misspelled the version number.

I still don't know where your error comes from, I use it internally for a project without any configurations and it just works???

xiCO2k commented 3 years ago

Thanks Will try it out, and get back to you.

rennokki commented 3 years ago

@xiCO2k For some reason I misspelled the tag again, sorry for the confusion. Just pushed 2.2.0 with 0.6 as default container.

xiCO2k commented 3 years ago

Got it. Thanks, will check it later today and get back to you.

xiCO2k commented 3 years ago

@rennokki if you can update the index.yaml file to have that version would be helpful to have it on my Chart.yaml dependencies

xiCO2k commented 3 years ago

besides that I run the repo directly and got the same issue:

There is a print:

xiCO2k commented 3 years ago

Hey @rennokki any luck checking this out?

Thanks, Francisco

rennokki commented 2 years ago

@xiCO2k

This is related to https://github.com/soketi/pws/issues/85. I have fixed the issues with that charts overall. I couldn't find this issue some days ago to also notify you. 😅

xiCO2k commented 2 years ago

Thanks @rennokki will do some tries.

soketi / charts

Update pWS chart version to 3.0 #4