sokratis12GR / ArmorPlus

ArmorPlus is a mod based on exploration, killing, building, getting geared up, fight the bosses and explore the depths of your worlds.
https://smarturl.it/armorplus?IQid=google
GNU Lesser General Public License v3.0
23 stars 23 forks source link

[1.16.3+] Armors that provide flight, will cause MekaSuit Bodyarmor's Gravitational Module to malfunction. #245

Closed ghost closed 3 years ago

ghost commented 3 years ago

Affected Versions: -Armor Plus version 16.1.1 (1.16.3) -Mekanism version 10.0.18.445 (1.16.4)

Affected Side: [x] Client [ ] Server (unsure, have not tested).

Issue: Armor pieces from creative flight bonus sets prevent Mekanism's Gravitational Module from functioning. If you equip a MekaSuit Bodyarmor with the Gravitational Module installed, and you equip any armor pieces from sets that will give creative flight if set condition is met (Ender Dragon armor pieces, Slayer armor pieces, etc.), the MekaSuit Bodyarmor's flight ability would immediately malfunction.

Additional Notes:

sokratis12GR commented 3 years ago

Hello, apologies for the rather late reply (I thought I had replied but apparently I haven't).

Thanks for the report but yeah that's the side effect of using setpiece matching for the armor, once I figure out a better way to do the set matching this will be no more ^^.

ghost commented 3 years ago

No problem! All is good. It's honestly not a big thing, just a minor issue or something. It did make me feel like a bit of an idiot when I was standing there spamming jump trying to fly, but that's really about it. More importantly, thank you for being an amazing mod author!

sokratis12GR commented 3 years ago

Hello, just wanted to note that this issue will be resolved in the next ArmorPlus update 16.3.0 ^^

sokratis12GR commented 3 years ago

image image

ghost commented 3 years ago

That's amazing! Thank you so much for taking the time to fix this! You are a great mod author, thank you.

sokratis12GR commented 3 years ago

Actually my bad, I don't think there is a possible fix for this when using the full set requirement, though I'll add a config option to allow "per-piece" effects, and while that is active it shouldn't interfere here.

sokratis12GR commented 3 years ago

Scratch my last message, after some trial and error, the issue has been fixed: Video Example

ghost commented 3 years ago

Cool! Thank you! <3

PS, I really thought you were gonna go as far as dying from fall damage in the demonstration.

sokratis12GR commented 3 years ago

Haha no worries, I'll push the update in a few days as there are still some things I want to improve/change and document. ^^