search

sol-eng / bike_predict

A demo of an end-to-end machine learning pipeline, using Posit Connect
92 stars 31 forks source link

use pins 1.0.0 syntax #12

Closed edavidaja closed 2 years ago

edavidaja commented 2 years ago

envvar auth for all pins, explicit by publisher name

closes #8

edavidaja commented 2 years ago

We may want to consider a substantial refactoring here--some of the data fetching parts of the package code appear to be breaking, there are some writes to the database that are hitting 10M rows and struggling against the limits of copy_to(), and because it's not always clear where the pins and db are being updated, it's hard to tell what breakage is coming from changes to pins vs other parts of the arch that need to be updated.

edavidaja commented 2 years ago

Also: it appears that the change to 1.0.0 makes it difficult to read pins published before that; it may make sense to republish all pinned content with that in mind. I'm not able to publish updates to several of the existing pins and didn't want to re-namespace them.

akgold commented 2 years ago

Yes, I'm getting failures almost every day. I haven't dug in because it's all still "working", but we should probably refactor.

Also -- https://github.com/sol-eng/bike_predict/issues/11

We should migrate RSC content to be off of main.

akgold commented 2 years ago

I wasn't sure from comment -- is this ready to merge, or need more work here before merging?

edavidaja commented 2 years ago

When I last tried I was unable to publish updates to a few of the pins and did not want to publish and move them all to my name, so I think more work is required before this can merge.

SamEdwardes commented 2 years ago

I think we can close this PR - major refactor done in #15.