search

sol-oriens / SR2-Community-Patch

Star Ruler 2 Community Patch - A collection of bug fixes and non-gameplay changing improvements
5 stars 4 forks source link

Sanity check: Support ships should not be transferrable between star systems #21

Open DaloLorn opened 3 years ago

DaloLorn commented 3 years ago

The discussion in #20 raised a secondary issue, specifically that you should not be able to transfer support ships between objects in different star systems.

The ability to do so has been a known issue for some time (see Discord, #cp-known-issues-and-minor-todos), but has never been resolved. The issue mentioned in Discord focused specifically on interstellar transfer of support satellites, because this had the added effect of teleporting satellites immediately.

Properly fixing this will necessarily prevent support ships from being transferred at all whilst in the interstellar void. IMO, this should be resolved by allowing them to be transferred within a fixed radius and/or the same star system, rather than focusing exclusively on being within the same star system. (For optimization purposes, though, check region equivalency before checking raw distance.)

Skeletonxf commented 3 years ago

Might this also require some GUI changes to properly indicate that the transfer is not allowed?

DaloLorn commented 3 years ago

Dunno, maybe? It might depend on the transfer method used. Some could probably afford to silently fail, or even never appear in the first place. (For instance, I think the context menu option could simply be removed when transfer is impossible.)

Skeletonxf commented 3 years ago

Removing the context menu seems like a good way to do it. Though the AI doesn't use the context menu so would also have to make it silently fail to stop the AI cheating.