search

solacecommunity / solace-prometheus-exporter

Prometheus Solace Exporter
MIT License
25 stars 24 forks source link

[Feature]: Adding support for "show message-vpn <vpn> rest rest-consumer <name> stats" #79

Open lwyic opened 10 hours ago

lwyic commented 10 hours ago

Feature Description

Currently the exporter doesn't handle rdp related stats. I'm looking for adding support for "show message-vpn rest rest-consumer stats".

Use Case

It's for monitoring the rdp rest-consumers for both messaging and gateway mode for a VPN.

Proposed Solution

I have the code written already to support this. I'm asking for permission to submit my code (in a separate branch).

GreenRover commented 10 hours ago

You need to fork this repo and create an pullrequest. https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request

lwyic commented 10 hours ago

So, I can't just git pull, then create a new branch, make the change and push the branch. I need to fork the project instead? OK, I'll follow the instructions to fork it then. thanks.

GreenRover commented 10 hours ago

yes, this is how github works