search

solana-developers / create-solana-dapp

CLI for creating Solana dApps on the fly
https://npmjs.com/package/create-solana-dapp
MIT License
326 stars 101 forks source link

[nextjs] mobile friendly header #32

Open nickfrosty opened 9 months ago

nickfrosty commented 9 months ago

the generated nextjs app is not mobile friendly. specifically, the header and links. when the screen size gets too small, the UI breaks.

Generator used:

note: this might also apply to the react app too. I have not yet checked.

kaksv commented 8 months ago

Can i also contribute to this?

beeman commented 8 months ago

Can i also contribute to this?

For sure, feel free to submit a PR that fixes this.

There is a contributing guide in the repo to help you set it up.

Alternatively you could scaffold a new project, make the changes and push it up to Github and I will merge them back into the templates.

kaksv commented 8 months ago

Alright, let me do so.

On Wed, Feb 7, 2024, 2:48 AM beeman @.***> wrote:

Can i also contribute to this?

For sure, feel free to submit a PR that fixes this.

There is a contributing guide in the repo to help you set it up.

Alternatively you could scaffold a new project, make the changes and push it up to Github and I will merge them back into the templates.

— Reply to this email directly, view it on GitHub https://github.com/solana-developers/create-solana-dapp/issues/32#issuecomment-1930961858, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIMXREINJGVII7MI2OJKUCLYSK6MBAVCNFSM6AAAAABCJKZP5CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZQHE3DCOBVHA . You are receiving this because you commented.Message ID: @.***>

kaksv commented 8 months ago

@beeman though I am good with the nextjs, tailwind and css, I am finding issues with Nx, any quick recommendation for farmiliarizing myself with it would be great. Otherwise I am failing to run it locally and see my changes.

beeman commented 8 months ago

@beeman though I am good with the nextjs, tailwind and css, I am finding issues with Nx, any quick recommendation for farmiliarizing myself with it would be great. Otherwise I am failing to run it locally and see my changes.

If you have tried using the steps described here and get stuck, feel free to send me a message on Discord (linked in my GitHub profile) and I can see where specifically our docs need clarification.

Alternatively, you can make the changes in a generated project and push that up to a new repo and I'll merge them in.