search

solana-developers / solana-actions

https://solana-developers.github.io/solana-actions/
Apache License 2.0
92 stars 38 forks source link

fix: transfer-sol get amount #1

Closed aLIEzsss4 closed 2 months ago

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
solana-actions ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 27, 2024 11:19am
nickfrosty commented 2 months ago

There is not a typo here, so your PR is not going to be approved/merged.

The href value reading as: ${baseHref}&amount={amount} uses the string literal {amount} as a template string for the action/blink clients to replace with the value input by the user. Rather than your suggestion of putting in a specific value of the variable amount. So if your PR was merged, it would actually break.

Thanks for looking into issues though :)