solana-labs / dapp-scaffold

Scaffolding for a dapp built on Solana
Apache License 2.0
1.76k stars 995 forks source link

chore: setting prettier and update eslint default config #322

Open pmpwith2i opened 1 year ago

pmpwith2i commented 1 year ago

Description

This PR introduces some changes to default configuration of eslint and also update packages configuration in order to use prettier and the formatter for tailwindCSS classes. This PR will introduce a refactor of many files in order to fit the new style rules, nothing changed in the core of the application.

Issue

This PR closes #291

pmpwith2i commented 1 year ago

Hi @DonnySolana, while using this scaffold I added some configurations and I think that could be useful for other users to use it. Feel free to remove/add rules on eslint or to deny this PR. After this changes some files will be broken so a refactor should be done, I could do it Thanks! ♥︎

DonnySolana commented 1 year ago

hey thanks! what will the refactor look like? If you do not mind doing it, it may make more sense to do it at once and make sure everything runs smooth.

pmpwith2i commented 1 year ago

hey thanks! what will the refactor look like? If you do not mind doing it, it may make more sense to do it at once and make sure everything runs smooth.

Hey, essentially most of the refactor would be only to fix code style like quotes and indent. Then there are some typing issues to solve, I’ll do it in these days:)

pmpwith2i commented 1 year ago

@DonnySolana I updated the code, almost of the 38 files changed are automatically updated by prettier and eslint, I just removed some memo not needed where the file are imported from an external module (because it never changes), like the notify