solana-labs / obsolete-spl-zk-token

Obsolete - don't use
https://github.com/solana-labs/solana-program-library/tree/master/token/program-2022/src/extension/confidential_transfer
145 stars 21 forks source link

Can't compile latest version #97

Open nicosey opened 2 years ago

nicosey commented 2 years ago

Getting errors:

Compiling spl-zk-token v0.1.0 (/Users/nicosey/projects/spl-zk-token/program) error[E0609]: no field balance on type &solana_zk_token_sdk::instruction::CloseAccountData --> program/src/processor.rs:445:51 445 if zk_token_account.available_balance != data.balance { ^^^^^^^ unknown field
= note: available fields are: `pubkey`, `ciphertext`, `proof`

Any idea?

samkim-crypto commented 2 years ago

Yes, the code has not yet been updated for the latest zk-token-sdk. This should be fixed in a day or two.

sparkydasrath commented 2 years ago

@samkim-crypto Good to know as I started making local fixes but will just wait for this instead. Thanks!

samkim-crypto commented 2 years ago

The errors should be fixed.

In the future, as per the migration plan (https://github.com/solana-labs/spl-zk-token/issues/91), please refer to https://github.com/solana-labs/solana-program-library solana-program-library/token/program-2022/ for the most up-to-date zk-token program.

sparkydasrath commented 2 years ago

Grabbed latest and got the builds going but ran into an issue when trying to execute the demo, but it seems super close now if you can help me sort out the last issue...

spl-zk-token/target/debug/zk-token-demo-cli -ul`
==> Creating token mint: 7pSrG5qvtPDmS6SHztRfJ5277yLzrHjm3Xzij956FYQL
Signature: 2s1dj2qDHrwrmR35SFhM3uEXgGyzKBk1p5FZtL4p86MbnJwrVa8t77JWSMyFsu7BCSfX7ybMcc2rcFV4kV7qSEqm
==> Creating token account with 100 tokens: 72PNCBGhkgfn3QoEhdbX5jB1SqSeyEp9HDUuCp9Z4Ctf
Signature: 3YQMVcix7PzcnFyv2vLtHepSbpRD75PYDsj4v3dxFhooHP7YrKMatJXX3uvi1ZzriaqhbKaD8Jwk6v5TxBndsvVL
==> Configuring confidential token account byyL5tV2VDqDsAb21gVwnPWHX65MG1YXySVXzGMMRJv
Signature: 67m3DSvSyWxuUcwBadgofeo2zTtDAeU9XEm21dVHvtMabRzQAwgqqsF9huny919zhFwuWsp8FiFNYo4x6fcVjq5w
==> Enabling credits on confidential token account byyL5tV2VDqDsAb21gVwnPWHX65MG1YXySVXzGMMRJv
Signature: 5gT62KNA9B4BxY2dgQnMR1cmvHbm47BPZ1EzdVBaEZpXT3ezHZ3pVxRmji5eTc8iPZTfG6oc4Xu2gRVpMMG6Uvte
==> Creating token account with 100 tokens: 6ANDB4VUaJxX8FwX4z41fVhK3yG48N9BgtFKg8z5uQfv
Signature: 5VEQTWo7iFqQ3JhKHEckFArPBdcVNi2LczSj3QfpnGvoN2nN4BGojUEkXrkjMfeKQnzFX9gnBSv9fP4g1hZJXPhd
==> Configuring confidential token account FrXah9hzkpRqpZR4ih8pDVtt3yE9Ca572e28iM1EDcq3
Signature: 5EXaea2Cdocp9veffV5iJEVbR7E9aHazPnkC6kfGJdK2wTCKTETRvK8C32ZK7GGXQrdrTSa9MgzEMe5aDN9uNKto
==> Enabling credits on confidential token account FrXah9hzkpRqpZR4ih8pDVtt3yE9Ca572e28iM1EDcq3
Signature: 5Pp92XqYpU4xtJUbi7FXsy1xkpTR6EAN9QW2dSXcRBV95MWpy4PJrcDXiubQAkEGn2Hfzq7mgtokTqZ5Kc5mUww4
==> Depositing 100 from 72PNCBGhkgfn3QoEhdbX5jB1SqSeyEp9HDUuCp9Z4Ctf to byyL5tV2VDqDsAb21gVwnPWHX65MG1YXySVXzGMMRJv
Signature: 2keeZhpRTUYpL541f6kdbjC9mVKtZzT2HXF6yrPkpwSSiLhdckJoFAcQsCgLqE1tgFUCbtBhczNoJMEmyA6sV9qe
==> Applying pending balance for byyL5tV2VDqDsAb21gVwnPWHX65MG1YXySVXzGMMRJv
Signature: 5aWUe1WzenH9Qn5kW5JT2kTSw9Pz9MdUJxPkdxp4LCoZamGj8scFPGfZs7qGvpWRgiCLorZd9DijLsL5MNahAFo
==> Transferring 100 confidentially from byyL5tV2VDqDsAb21gVwnPWHX65MG1YXySVXzGMMRJv to FrXah9hzkpRqpZR4ih8pDVtt3yE9Ca572e28iM1EDcq3
error: error: send transaction: RPC response error -32602: encoded solana_sdk::transaction::versioned::VersionedTransaction too large: 2640 bytes (max: encoded/raw 1644/1232) 
mvines commented 2 years ago

solana_sdk::transaction::versioned::VersionedTransaction too large: 2640 bytes (max: encoded/raw 1644/1232

This error is basically expected at this point, unless you're running a local validator with this hacky patch: https://github.com/solana-labs/spl-zk-token/blob/master/scripts/0001-feat-double-PACKET_DATA_SIZE.patch

Work to enable larger transactions is still ongoing, which is a blocker for actually shipping zk-tokens

sparkydasrath commented 2 years ago

Thanks for the super fast update. Based on the setup file, the patch was supposed to get applied automagically so wonder why it didn't take. I will run just the section that deals with the patching and redo all the steps to see how far I get. This is cool stuff btw.

sparkydasrath commented 2 years ago

I got why the patch didn't run - I keep having issues running the setup script (github keeps complaining about access to solana) so I manually cloned the solana monorepo into the spk-zk folder and followed the rest of the steps - but skipping the patching part

sparkydasrath commented 2 years ago

New error now

==> Transferring 100 confidentially from 3ZTqvNePmFnPb2op2c2yVS7zYMPMTjHweNqYPg51muJN to B8ZLFMrJw7wBrus4ENiSd9HrNMjrxdX1qDbTdVZzkDJD
error: error: send transaction: RPC response error -32002: Transaction simulation failed: Error processing Instruction 0: invalid instruction data [4 log messages]
mvines commented 2 years ago

This repo is in the process of being decommissioned (https://github.com/solana-labs/spl-zk-token/issues/91) Here's the new home for zk-token: https://github.com/solana-labs/solana-program-library/tree/master/token/program-2022/src/extension/confidential_transfer

The remaining bits in this repo, the tests and demo program, will be migrated to the new location pretty soon and then this repo will be deleted

sparkydasrath commented 2 years ago

Should I add this build issue over there then - would that be helpful or this is a known issue that will be sorted out soon enough?

mvines commented 2 years ago

It's a known issue, the demo/tests haven't been migrated yet. Thanks for your interest in this new feature though!

harsh4786 commented 2 years ago

I've been waiting for this too,

Grabbed latest and got the builds going but ran into an issue when trying to execute the demo, but it seems super close now if you can help me sort out the last issue...

spl-zk-token/target/debug/zk-token-demo-cli -ul`
==> Creating token mint: 7pSrG5qvtPDmS6SHztRfJ5277yLzrHjm3Xzij956FYQL
Signature: 2s1dj2qDHrwrmR35SFhM3uEXgGyzKBk1p5FZtL4p86MbnJwrVa8t77JWSMyFsu7BCSfX7ybMcc2rcFV4kV7qSEqm
==> Creating token account with 100 tokens: 72PNCBGhkgfn3QoEhdbX5jB1SqSeyEp9HDUuCp9Z4Ctf
Signature: 3YQMVcix7PzcnFyv2vLtHepSbpRD75PYDsj4v3dxFhooHP7YrKMatJXX3uvi1ZzriaqhbKaD8Jwk6v5TxBndsvVL
==> Configuring confidential token account byyL5tV2VDqDsAb21gVwnPWHX65MG1YXySVXzGMMRJv
Signature: 67m3DSvSyWxuUcwBadgofeo2zTtDAeU9XEm21dVHvtMabRzQAwgqqsF9huny919zhFwuWsp8FiFNYo4x6fcVjq5w
==> Enabling credits on confidential token account byyL5tV2VDqDsAb21gVwnPWHX65MG1YXySVXzGMMRJv
Signature: 5gT62KNA9B4BxY2dgQnMR1cmvHbm47BPZ1EzdVBaEZpXT3ezHZ3pVxRmji5eTc8iPZTfG6oc4Xu2gRVpMMG6Uvte
==> Creating token account with 100 tokens: 6ANDB4VUaJxX8FwX4z41fVhK3yG48N9BgtFKg8z5uQfv
Signature: 5VEQTWo7iFqQ3JhKHEckFArPBdcVNi2LczSj3QfpnGvoN2nN4BGojUEkXrkjMfeKQnzFX9gnBSv9fP4g1hZJXPhd
==> Configuring confidential token account FrXah9hzkpRqpZR4ih8pDVtt3yE9Ca572e28iM1EDcq3
Signature: 5EXaea2Cdocp9veffV5iJEVbR7E9aHazPnkC6kfGJdK2wTCKTETRvK8C32ZK7GGXQrdrTSa9MgzEMe5aDN9uNKto
==> Enabling credits on confidential token account FrXah9hzkpRqpZR4ih8pDVtt3yE9Ca572e28iM1EDcq3
Signature: 5Pp92XqYpU4xtJUbi7FXsy1xkpTR6EAN9QW2dSXcRBV95MWpy4PJrcDXiubQAkEGn2Hfzq7mgtokTqZ5Kc5mUww4
==> Depositing 100 from 72PNCBGhkgfn3QoEhdbX5jB1SqSeyEp9HDUuCp9Z4Ctf to byyL5tV2VDqDsAb21gVwnPWHX65MG1YXySVXzGMMRJv
Signature: 2keeZhpRTUYpL541f6kdbjC9mVKtZzT2HXF6yrPkpwSSiLhdckJoFAcQsCgLqE1tgFUCbtBhczNoJMEmyA6sV9qe
==> Applying pending balance for byyL5tV2VDqDsAb21gVwnPWHX65MG1YXySVXzGMMRJv
Signature: 5aWUe1WzenH9Qn5kW5JT2kTSw9Pz9MdUJxPkdxp4LCoZamGj8scFPGfZs7qGvpWRgiCLorZd9DijLsL5MNahAFo
==> Transferring 100 confidentially from byyL5tV2VDqDsAb21gVwnPWHX65MG1YXySVXzGMMRJv to FrXah9hzkpRqpZR4ih8pDVtt3yE9Ca572e28iM1EDcq3
error: error: send transaction: RPC response error -32602: encoded solana_sdk::transaction::versioned::VersionedTransaction too large: 2640 bytes (max: encoded/raw 1644/1232) 

Were you trying this on devnet?