Governance: time to vote eneded calculates with cool off time

solana-labs / oyster

oyster.vercel.app

Apache License 2.0

115 stars 127 forks source link

Open ochaloup opened 1 year ago

ochaloup commented 1 year ago

The contract of SPL Gov works with cool off time to assert if it's time to finalize vote. https://github.com/solana-labs/solana-program-library/blob/master/governance/program/src/state/proposal.rs#L340 While there is the greater than not with 'equal' in comparision.

vercel[bot] commented 1 year ago

@ochaloup is attempting to deploy a commit to the Solana Foundation Team on Vercel.

A member of the Team first needs to authorize it.

ochaloup commented 1 year ago

@SebastianBor thanks for the review. I updated the pull request trying to follow your point. Please take a look.

I'm not sure about maxVotingTime setter for backwards compatibility reasons. Decided to not to add but not sure.

ochaloup commented 1 year ago