Closed ksolana closed 1 year ago
Merging #537 (f1f0042) into main (32b1a6f) will decrease coverage by
0.01%
. The diff coverage is85.71%
.
@@ Coverage Diff @@
## main #537 +/- ##
==========================================
- Coverage 88.41% 88.41% -0.01%
==========================================
Files 24 24
Lines 10258 10264 +6
==========================================
+ Hits 9070 9075 +5
- Misses 1188 1189 +1
Files | Coverage Δ | |
---|---|---|
src/elf_parser_glue.rs | 68.53% <ø> (ø) |
|
src/elf_parser/mod.rs | 81.84% <85.71%> (+0.02%) |
:arrow_up: |
let me know if it is okay to merge the patch.
lgtm, but maybe confirm @Lichtso approves before merging.
Took the liberty to push the following changes:
String::from_utf8_lossy()
which uses replacement characters and can not fail, so we don't have to deal with UTF-8 errors.test_long_section_name
from execution.rs to elf.rs as it is about ELF parsing.#[should_panic()]
with assert_error!()
so we can programmatically cut the name to the desired length.InvalidStringTooLong
to just StringTooLong
. InvalidString
can be removed because it is only used inside a debug formater.Resolve #532
Took the liberty to push the following changes:
* Used `String::from_utf8_lossy()` which uses replacement characters and can not fail, so we don't have to deal with UTF-8 errors. * Moved `test_long_section_name` from execution.rs to elf.rs as it is about ELF parsing. * Replaced `#[should_panic()]` with `assert_error!()` so we can programmatically cut the name to the desired length. * Renamed `InvalidStringTooLong` to just `StringTooLong`. `InvalidString` can be removed because it is only used inside a debug formater.
Thanks! looks better now.
Addresses: #532
With the patch error message now looks like: