search

solana-labs / rbpf

Rust virtual machine and JIT compiler for eBPF programs
Apache License 2.0
272 stars 163 forks source link

Cleanup - Removes `ELF_INSN_DUMP_OFFSET` #541

Closed Lichtso closed 11 months ago

Lichtso commented 11 months ago

Fixes #539

codecov-commenter commented 11 months ago

Codecov Report

Merging #541 (c46990b) into main (06e22d7) will decrease coverage by 0.02%. The diff coverage is 86.66%.

@@            Coverage Diff             @@
##             main     #541      +/-   ##
==========================================
- Coverage   88.43%   88.41%   -0.02%     
==========================================
  Files          24       24              
  Lines       10275    10259      -16     
==========================================
- Hits         9087     9071      -16     
  Misses       1188     1188
Files Coverage Δ
src/ebpf.rs 79.59% <ø> (ø)
src/elf.rs 87.61% <100.00%> (-0.07%) :arrow_down:
src/static_analysis.rs 65.82% <0.00%> (ø)
src/verifier.rs 97.93% <91.66%> (-0.08%) :arrow_down:
ksolana commented 11 months ago

should we add test case from https://github.com/solana-labs/rbpf/issues/539 or the existing tests cover it already?

Lichtso commented 11 months ago

This does not change the behavior / functionality. It is purely a cosmetic change. And there are lots of tests which were adjusted, all had the display offset removed. So I would say there is plenty of coverage.