search

solana-labs / rbpf

Rust virtual machine and JIT compiler for eBPF programs
Apache License 2.0
272 stars 163 forks source link

Test move binary is parsed correctly by the GoblinParser #555

Closed ksolana closed 5 months ago

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.42%. Comparing base (179a0f9) to head (d7835d6).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #555 +/- ## ========================================== + Coverage 88.34% 89.42% +1.07% ========================================== Files 24 23 -1 Lines 10282 9937 -345 ========================================== - Hits 9084 8886 -198 + Misses 1198 1051 -147 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Lichtso commented 5 months ago

The GoblinParser is deprecated (see https://github.com/solana-labs/rbpf/pull/348 and https://github.com/solana-labs/solana/issues/30497).

ksolana commented 5 months ago

The GoblinParser is deprecated (see #348 and solana-labs/solana#30497).

is there a doc that shows the difference between their specifications? That might be useful when we start relying on the new parser.

Lichtso commented 5 months ago

https://github.com/solana-labs/rbpf/pull/290 but not all were implemented.