search

solana-labs / solana-web3.js

Solana JavaScript SDK
https://solana-labs.github.io/solana-web3.js
MIT License
1.97k stars 792 forks source link

Fixed a bug where the RPC coalescer would leave the application with no request even though there were consumers #2819

Closed steveluscher closed 3 weeks ago

steveluscher commented 3 weeks ago

Summary

If multiple consumers made the same RPC call, then all of them aborted, then another consumer made the same RPC call, all in the same runloop, you'd end up with zero inflight requests and the remaining callers would never recieve their response.

changeset-bot[bot] commented 3 weeks ago

🦋 Changeset detected

Latest commit: 341c8b8e85fd52cd0e6137e7a0c2b7845a32f642

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 37 packages | Name | Type | | --------------------------------------------- | ----- | | @solana/rpc | Patch | | @solana/web3.js-experimental | Patch | | @solana/rpc-graphql | Patch | | @solana/transaction-confirmation | Patch | | @solana/accounts | Patch | | @solana/addresses | Patch | | @solana/assertions | Patch | | @solana/codecs-core | Patch | | @solana/codecs-data-structures | Patch | | @solana/codecs-numbers | Patch | | @solana/codecs-strings | Patch | | @solana/codecs | Patch | | @solana/compat | Patch | | @solana/errors | Patch | | @solana/fast-stable-stringify | Patch | | @solana/functional | Patch | | @solana/instructions | Patch | | @solana/keys | Patch | | @solana/options | Patch | | @solana/programs | Patch | | @solana/react | Patch | | @solana/rpc-api | Patch | | @solana/rpc-parsed-types | Patch | | @solana/rpc-spec-types | Patch | | @solana/rpc-spec | Patch | | @solana/rpc-subscriptions-api | Patch | | @solana/rpc-subscriptions-spec | Patch | | @solana/rpc-subscriptions-transport-websocket | Patch | | @solana/rpc-subscriptions | Patch | | @solana/rpc-transformers | Patch | | @solana/rpc-transport-http | Patch | | @solana/rpc-types | Patch | | @solana/signers | Patch | | @solana/sysvars | Patch | | @solana/transaction-messages | Patch | | @solana/transactions | Patch | | @solana/webcrypto-ed25519-polyfill | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

steveluscher commented 3 weeks ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @steveluscher and the rest of your teammates on Graphite Graphite

github-actions[bot] commented 4 days ago

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.