solana-labs / solana-web3.js

Solana JavaScript SDK
https://solana-labs.github.io/solana-web3.js
MIT License
1.97k stars 791 forks source link

`setTransactionMessageFeePayer{Signer}` now accepts a broader range of inputs #2874

Closed steveluscher closed 4 days ago

steveluscher commented 6 days ago

Summary

These functions would not accept a simple CompilableTransactionMessage as input. Furthermore, this type was intended to unset the existing fee payer and replace it with the one passed in. Instead, this was producing the union of the old and new fee payers.

Test Plan

pnpm turbo compile:typedefs

Closes #2854.

changeset-bot[bot] commented 6 days ago

⚠️ No Changeset found

Latest commit: 58d7a9bb6a538b59610a211d6f8bd0005981c282

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

steveluscher commented 6 days ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @steveluscher and the rest of your teammates on Graphite Graphite

steveluscher commented 6 days ago

I made you the author of the commit, @lorisleiva, since this was your find.

steveluscher commented 4 days ago

Imma ship this PR none the less, because these other bugs are unrelated to the original bug.