search

solana-labs / solana-web3.js

Solana JavaScript SDK
https://solana-labs.github.io/solana-web3.js
MIT License
2.12k stars 847 forks source link

reafactor(Agave 2.0): Remove All Instances of `getFees` and `getFeeCalculatorForBlockhash` #2896

Closed 0xIchigo closed 2 months ago

0xIchigo commented 3 months ago

This PR aims to start addressing #2859 by eliminating all instances of getFees and getFeeCalculatorForBlockhash as they'll be removed in Agave 2.0

changeset-bot[bot] commented 3 months ago

⚠️ No Changeset found

Latest commit: 3f853aacfef53d638b8366c0f1a5f442daa633ea

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

steveluscher commented 3 months ago

Thanks for this!

Before you go too far down this rabbit hole, I've started to have a few second thoughts here.

  1. Responsibly removing these methods would require a major version bump, which would take legacy web3.js to 2.0.
  2. The new library that we actually intend on releasing as web3.js 2.0 already has these methods gone.

I think maybe we just cut our losses for legacy, and close #2859 by releasing the new library. Two birds, one stone.

0xIchigo commented 3 months ago

No worries @steveluscher! I figured I'd start with this PR and go from there. Should I close this PR then or leave it open for the time being?

github-actions[bot] commented 1 month ago

Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up.