Coalescer is not handling an explicit abort exception, and it's bubbling up uncaught

solana-labs / solana-web3.js

Solana JavaScript SDK

https://solana-labs.github.io/solana-web3.js

MIT License

2.2k stars 875 forks source link

Coalescer is not handling an explicit abort exception, and it's bubbling up uncaught #3512

Closed steveluscher closed 2 weeks ago

steveluscher commented 2 weeks ago

Repro: https://codesandbox.io/p/sandbox/solana-javascript-sdk-release-candidate-3-demo-42pnj4?file=%2Fsrc%2Findex.ts%3A14%2C19

Uncaught EXPLICIT_ABORT_TOKEN:

This object is thrown from the request that underlies a series of coalesced requests when the last request in that series aborts

steveluscher commented 2 weeks ago

Ooooh. Actually, upon reflection, I really hope this is just owing to Codesandbox hot reloading. I took a look at the code and it appears to be impossible to break in this way.

steveluscher commented 2 weeks ago

Yeah, nevermind. This was because of Parcel hot reload or whatever re-running the module factory of the code where EXPLICIT_ABORT_TOKEN was created, breaking the try/catch that was supposed to keep it from bubbling up.

github-actions[bot] commented 1 week ago

Because there has been no activity on this issue for 7 days since it was closed, it has been automatically locked. Please open a new issue if it requires a follow up.