solana-labs / solana

Web-Scale Blockchain for fast, secure, scalable, decentralized apps and marketplaces.
https://solanalabs.com
Apache License 2.0
13.04k stars 4.21k forks source link

Explorer needs to also grab mint metadata from metaplex for fungible tokens #23748

Closed jacobcreech closed 2 years ago

jacobcreech commented 2 years ago

Problem

Token-list is on its way to being deprecated. In order to have a smooth transition, we should support the new way of grabbing token metadata.

Proposed Solution

Use the existing Metadata.load function from @metaplex-foundation/mpl-token-metadata that we use to fill the metadata card and use the new fungible token metadata standard to show wallet metadata on a mint page. This will be alongside tokenlist.

The logic is as follows:

An example of a token mint account with fungible token metadata can be found here

jstarry commented 2 years ago

@roederw any ideas on how token metadata can be verified to prevent spoofing?

jacobcreech commented 2 years ago

@jstarry Would love your thoughts on how we could get this implemented without the unverified tag.

The way I see it, we have a two options:

  1. Have wallets implement a blacklist and ingest their blacklist
    • Pros: Wallets already get the reports about scams, so they'll be able to blacklist accordingly
    • Cons: Reactive instead of Proactive
  2. Work with Metaplex team to create a Fungible Token standard that only disallows duplicate symbols
    • Pros: Proactive
    • Cons: Can still lead to scams and symbol squatting

What do you think? Trying to get a path to ultimately deprecating the token-list as a whole and moving on to a better developer experience for creating tokens.

jstarry commented 2 years ago

The latter with an auction system for ticker symbols sounds like a good route to me. Seems like something Metaplex can own.

jacobcreech commented 2 years ago

Closing issue as Metaplex fungible token metadata was added to the explorer in #24496 and updated in #24750