solana-labs / solana

Web-Scale Blockchain for fast, secure, scalable, decentralized apps and marketplaces.
https://solanalabs.com
Apache License 2.0
13.15k stars 4.25k forks source link

Account Lock check is not checking for mutability #35682

Closed jwalin12 closed 5 hours ago

jwalin12 commented 5 hours ago

Problem

The TooManyAccountLocks error is currently checking the length of the AccountKeys for a SantizedMessage. However, this does not allow for transactions with more than 64 accounts, even if the transaction is locking less than 64 accounts. This is a blocking issue for many features on our app, since our transactions are quite large and use multiple LUTs.

Proposed Solution

Instead of using account_keys.len(), Change the TooManyAccountLocks error to check accountKeys the number of accounts where writable = true. Only error if the writable amount is too large.

github-actions[bot] commented 5 hours ago

This repository is no longer in use. Please re-open this issue in the agave repo: https://github.com/anza-xyz/agave