solana-mobile / Minty-fresh

An open source mobile first implementation of NFT minting on solana
https://solanamobile.com/
Apache License 2.0
45 stars 18 forks source link

Wait for confirmations #132

Closed ankur2136 closed 1 year ago

ankur2136 commented 1 year ago

After minting a NFTs sometimes the MyMints screen still shows the old NFT count probably because the transaction is not yet complete when we fetch the details.

ankur2136 commented 1 year ago

As per code we are already waiting for confirmations with a timeout for 30 seconds. So unsure why the rpcs are sometimes spitting older information. Maybe there is a delay in processing somewhere.

ankur2136 commented 1 year ago

I think the issue here is that when we mint, we wait for the commitment to be Finalized but when we are polling the NFTs on the account we are waiting for CONFIRMED

the discrepancy might cause the diff in data.

Funkatronics commented 1 year ago

when we mint, we wait for the commitment to be Finalized

I don't think this is true, I am looking at the code now and our commitment level is CONFIRMED

when we are polling the NFTs on the account we are waiting for CONFIRMED

this does make sense/is not relevant. the my mints page only reads data, it does not send any transactions.

We can:

creativedrewy commented 1 year ago

Is this done @ankur2136 @Funkatronics ?