solana-mobile / dapp-publishing

Apache License 2.0
54 stars 15 forks source link

Missing icon field does not fail validation step #148

Closed creativedrewy closed 1 year ago

creativedrewy commented 1 year ago

Icon is required for all three of the publishing entities, thus the validation check should enforce.

creativedrewy commented 1 year ago

@konoart Can you tell me more about what you're seeing with problems with the icon? Validation checks appear to be working with the sample data I'm trying.

konoart commented 1 year ago

@creativedrewy it's about a media with purpose = icon

creativedrewy commented 1 year ago

@konoart can you give a little more context about what data issues you are seeing? I'm just not seeing the ability to mint NFTs without the "icon" value.

konoart commented 1 year ago

@creativedrewy , sure. We have a release submitted: https://czt544ueexwyz55ohcy73l3x45uvfzaldl7llsfux2mec7l2aw2a.arweave.net/FmfecoQl7Yz3rjix_a9352lS5Asa_rXItL6YQX16BbQ It doesn't have a media with purpose = icon that's why it's failing.