search

solana-mobile / dapp-publishing

Apache License 2.0
54 stars 15 forks source link

Add a warning message if locale list is over 25 #166

Closed ankur2136 closed 1 year ago

ankur2136 commented 1 year ago

This warns the developers to configure the locales correctly.

ankur2136 commented 1 year ago

We definitely need this, otherwise every other dApp is claiming to have 85 language support but they dont support anything other than English. Or we need a release section where publishers manually enter the locales they support.

creativedrewy commented 1 year ago

Yeah not denying that something like this could be beneficial; I just think @sdlaver will have some thoughts about the appropriate placement/behavior of it.

ankur2136 commented 1 year ago

The more I think about this it feels inappropriate to ask developers to add resConfig to their build files to limit locales. (even if its a good idea in most cases)

171 for considering to add locale in the publishing specs.

sdlaver commented 1 year ago

The more I think about this it feels inappropriate to ask developers to add resConfig to their build files to limit locales. (even if its a good idea in most cases)

171 for considering to add locale in the publishing specs.

We have to ask them to add it somewhere - why not in the canonical location for expressing which languages an app supports? For every single dev I've reached out to about this issue, they've been willing, they just didn't know that this was a thing.