search

solana-mobile / dapp-publishing

Apache License 2.0
54 stars 15 forks source link

Add locale field in the publishing spec #171

Closed ankur2136 closed 1 year ago

ankur2136 commented 1 year ago

Relying on aapt2 for list of locale is not a good idea.

Most apps depend on compat libraries which are supported in a ton of languages (85). However most apps dont support more than English or a few other.

If the app is not minified to remove unnecessary resources/translations then everything gets packaged in the apk. Technically the app supports all 85 languages but it might be just be a few string which are coming from compat library in all languages.

The best judge of what languages a dApp is supporting the developer and they should explicitly specify which locales are supported rather than relying on aapt2 to extract this.

ankur2136 commented 1 year ago

Decision: Will continue using aapt2 to figure locales and warn developers to limit resource configurations if not in use.