solana-mobile / dapp-publishing

Apache License 2.0
54 stars 15 forks source link

`sendAndConfirmTransaction` usage should include `minContextSlot` #179

Closed sdlaver closed 1 year ago

sdlaver commented 1 year ago

As of filing this issue, there are 3 instances in the codebase that do not provide minContextSlot: https://github.com/search?q=repo%3Asolana-mobile%2Fdapp-publishing%20sendAndConfirmTransaction&type=code

This makes these operations vulnerable to race conditions where a blockhash is retrieved from RPC server A, but has not yet become known (at the requested confirmation level) on RPC server B, causing transactions to fail.