search

solana-mobile / dapp-publishing

Apache License 2.0
54 stars 15 forks source link

Update short_description constraint to 30 chars #202

Closed creativedrewy closed 1 year ago

creativedrewy commented 1 year ago

Addresses #195

sdlaver commented 1 year ago

I think we need to do a soft-rollout of this change, since publishers have already started using 50 characters. A warning in the next version, followed by enforcement in the following version.

creativedrewy commented 1 year ago

So then, this PR likely should be closed, correct? How should we get the word out about the impending change? Just direct comms, or update the "release notes" section in the CLI here?

sdlaver commented 1 year ago

I'd detect between 30 and 50 chars, and print a warning to the CLI. We should add it to that "release notes" blurb we print out when running the tool as well.

creativedrewy commented 1 year ago

Love this! Will update

creativedrewy commented 1 year ago

Actually, I'm going to revert this PR and start over w/ new requirements