solana-mobile / mobile-wallet-adapter

Other
222 stars 91 forks source link

Lot of dApps does not provide `name` and `icon` #428

Open kackogut opened 1 year ago

kackogut commented 1 year ago

Since mIconUri and mIdentityName fields are @Nullable a lot of dApps does not provide them or provide them only for the first authorize request. Some examples:

A good example of what Wallets might expect is https://orca.so/ which always provide both of those fields for all requests.

Michaelsulistio commented 1 year ago

For Mobile dApps that have this issue, look at the Authorize and Reauthorize of these dApp integration guides:

For Web dApps that have this issue with mobile wallet apps, look at the Advanced Usage section.

You'll need to provide the App Identity metadata of identityName, iconUri, and identityUri. This way users will be able to recognize your dApp during the transaction signing/sending flow.

Michaelsulistio commented 1 year ago

Current status for each Web dApp. Repro:

Some wallets like Solflare, do some caching/verification on their end to fill in missing app icons, but wallets like Phantom do not do this, and solely rely on the metadata passed in from App Identity.

Web App flow: Orca (✅) Mango Tensor Magic Eden Marinade Finance
Screenshot_20230420-092538 Screenshot_20230420-092354 Screenshot_20230420-092507 Screenshot_20230420-092425 Screenshot_20230420-093411
safaiyeh commented 1 year ago

+1 on requiring these fields